[asterisk-dev] [Code Review] 4067: CallerID: Fix parsing regression

opticron reviewboard at asterisk.org
Thu Oct 9 14:37:17 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4067/
-----------------------------------------------------------

(Updated Oct. 9, 2014, 2:37 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address Richard's comments.


Bugs: ASTERISK-24406
    https://issues.asterisk.org/jira/browse/ASTERISK-24406


Repository: Asterisk


Description
-------

This fixes a regression in callerid parsing introduced when another bug was fixed. This bug occurred when the name was composed entirely of DTMF keys and quoted without a number section (<>). 


Diffs (updated)
-----

  branches/1.8/tests/test_callerid.c 424965 
  branches/1.8/main/callerid.c 424965 

Diff: https://reviewboard.asterisk.org/r/4067/diff/


Testing
-------

Verified that the patch fixed the reporter's reproduction and verified that the new unit test passes with the patch and fails without it.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141009/6804a3c1/attachment.html>


More information about the asterisk-dev mailing list