[asterisk-dev] [Code Review] 4067: CallerID: Fix parsing regression

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4067/#review13483
-----------------------------------------------------------



branches/1.8/main/callerid.c
<https://reviewboard.asterisk.org/r/4067/#comment24005>

    One declaration per line. :)



branches/1.8/main/callerid.c
<https://reviewboard.asterisk.org/r/4067/#comment24004>

    This isn't always going to work.  The first thing ast_strip_quoted() does is ast_strip() to remove leading and trailing blanks.  Then it sees about removing the quotes.
    
    Suggest manually doing ast_strip() before calling ast_strip_quoted() to detect that just quotes were stripped.


- rmudgett


On Oct. 9, 2014, 1:59 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4067/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 1:59 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24406
>     https://issues.asterisk.org/jira/browse/ASTERISK-24406
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This fixes a regression in callerid parsing introduced when another bug was fixed. This bug occurred when the name was composed entirely of DTMF keys and quoted without a number section (<>). 
> 
> 
> Diffs
> -----
> 
>   branches/1.8/tests/test_callerid.c 424965 
>   branches/1.8/main/callerid.c 424965 
> 
> Diff: https://reviewboard.asterisk.org/r/4067/diff/
> 
> 
> Testing
> -------
> 
> Verified that the patch fixed the reporter's reproduction and verified that the new unit test passes with the patch and fails without it.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141009/e95e0823/attachment.html>