[asterisk-dev] [Code Review] 4035: Dialplan function to get first/head caller channel on queue

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4035/#review13429
-----------------------------------------------------------



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/4035/#comment23962>

    Suggest: "Return caller at the specified position in a queue."



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/4035/#comment23956>

    AST_STANDARD_APP_ARGS() modifys data.  use
    char *parse;
    ...
    parse = ast_strdupa(data);
    AST_STANDARD_APP_ARGS(args, parse);
    
    to work on your own copy of the string.



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/4035/#comment23957>

    This check is redundant as you will catch a missing argument with the following checks.



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/4035/#comment23958>

    Suggest "The <queuename> parameter is required.\n"



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/4035/#comment23961>

    guidelines: variable declarations go at the beginning of a block.
    
    struct call_queue tmpq;
    ...
    memset(&tmpq, 0, sizeof(tmpq));
    tmpq.name = args.queuename;
    



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/4035/#comment23959>

    idem



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/4035/#comment23960>

    use sscanf for better error detection.
    
    if (sscanf(args.position, "%30d", &position) != 1) {
      ast_log(...);
      return -1;
    }



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/4035/#comment23953>

    use ast_copy_string() instead


- rmudgett


On Oct. 1, 2014, 7:32 a.m., Kristian Høgh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4035/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 7:32 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24365
>     https://issues.asterisk.org/jira/browse/ASTERISK-24365
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The function returns the caller at specified position in a queue.
> 
> Noop(${QUEUE_GET_CHANNEL(queuename), 2})
> "SIP/peer-00000002", if queue exist and have at least 2 callers
> 
> Noop(${QUEUE_GET_CHANNEL(queuename), 1})
> "SIP/peer-00000000", if queue exist and have at least 1 caller
> 
> 
> Before diff r3:
> The function returns the first caller in a specific queue.
> Noop(${QUEUE_GET_FIRSTCHANNEL(queuename)})
> "SIP/peer-00000002", if queue exist and is non-empty
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_queue.c 424149 
> 
> Diff: https://reviewboard.asterisk.org/r/4035/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kristian Høgh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141001/c75515c9/attachment-0001.html>