[asterisk-dev] [Code Review] 4035: Dialplan function to get first/head caller channel on queue

Kristian Høgh reviewboard at asterisk.org
Wed Oct 1 07:32:27 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4035/
-----------------------------------------------------------

(Updated Oct. 1, 2014, 12:32 p.m.)


Review request for Asterisk Developers.


Changes
-------

Use qe->pos instead of counter to find requested position


Bugs: ASTERISK-24365
    https://issues.asterisk.org/jira/browse/ASTERISK-24365


Repository: Asterisk


Description
-------

The function returns the caller at specified position in a queue.

Noop(${QUEUE_GET_CHANNEL(queuename), 2})
"SIP/peer-00000002", if queue exist and have at least 2 callers

Noop(${QUEUE_GET_CHANNEL(queuename), 1})
"SIP/peer-00000000", if queue exist and have at least 1 caller


Before diff r3:
The function returns the first caller in a specific queue.
Noop(${QUEUE_GET_FIRSTCHANNEL(queuename)})
"SIP/peer-00000002", if queue exist and is non-empty


Diffs (updated)
-----

  /trunk/apps/app_queue.c 424149 

Diff: https://reviewboard.asterisk.org/r/4035/diff/


Testing
-------


Thanks,

Kristian Høgh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141001/5b5c28ef/attachment.html>


More information about the asterisk-dev mailing list