[asterisk-dev] [Code Review] 4149: main/file.c: fix possible extra ast_module_unref to format modules

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4149/
-----------------------------------------------------------

(Updated Nov. 6, 2014, 6:10 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 427464


Bugs: ASTERISK-24492
    https://issues.asterisk.org/jira/browse/ASTERISK-24492


Repository: Asterisk


Description
-------

fn_wrapper only adds a reference to the format's module if the file was able to be opened.  If not this causes an unmatched ast_module_unref in filestream_destructor.


Diffs
-----

  /branches/11/main/file.c 427255 

Diff: https://reviewboard.asterisk.org/r/4149/diff/


Testing
-------

Verified the issue and fix with tests/apps/voicemail/play_message + r4141.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141106/93adbc82/attachment-0001.html>