[asterisk-dev] [Code Review] 4149: main/file.c: fix possible extra ast_module_unref to format modules

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4149/#review13683
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On Nov. 4, 2014, 11:11 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4149/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 11:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24492
>     https://issues.asterisk.org/jira/browse/ASTERISK-24492
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> fn_wrapper only adds a reference to the format's module if the file was able to be opened.  If not this causes an unmatched ast_module_unref in filestream_destructor.
> 
> 
> Diffs
> -----
> 
>   /branches/11/main/file.c 427255 
> 
> Diff: https://reviewboard.asterisk.org/r/4149/diff/
> 
> 
> Testing
> -------
> 
> Verified the issue and fix with tests/apps/voicemail/play_message + r4141.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141105/a6b91d79/attachment.html>