[asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3525/#review11955
-----------------------------------------------------------

Ship it!


I still have some mixed feelings about the way this test was approached - I would have expected to see all of the SIP traffic handled through SIPp scenarios, and not have some subset of the attended transfer actually being managed through Asterisk. I think in the long run, that will make it rather challenging for someone to approach and re-use these scenarios in other tests.

That being said, this does actually do a SIP attended transfer, and it's certainly more stable than the PJSUA approach so... fair enough.

- Matt Jordan


On May 20, 2014, 1:37 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3525/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 1:37 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-23641
>     https://issues.asterisk.org/jira/browse/ASTERISK-23641
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This reworks a significant portion of the ARI attended transfer test to avoid dependence on pjsua since it has the tendency to cause sporadic (and sometimes consistent) test failures. The reworked test uses SIPp with 3PCC to manage the transfer scenario.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml 5043 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referer.xml PRE-CREATION 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referee.xml PRE-CREATION 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py 5043 
>   asterisk/trunk/contrib/sipp/transfer/referer.xml PRE-CREATION 
>   asterisk/trunk/contrib/sipp/transfer/referee.xml PRE-CREATION 
>   asterisk/trunk/contrib/sipp/table_of_contents 5043 
> 
> Diff: https://reviewboard.asterisk.org/r/3525/diff/
> 
> 
> Testing
> -------
> 
> Ensured that the test was operating as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140522/214fae08/attachment-0001.html>