<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3525/">https://reviewboard.asterisk.org/r/3525/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I still have some mixed feelings about the way this test was approached - I would have expected to see all of the SIP traffic handled through SIPp scenarios, and not have some subset of the attended transfer actually being managed through Asterisk. I think in the long run, that will make it rather challenging for someone to approach and re-use these scenarios in other tests.
That being said, this does actually do a SIP attended transfer, and it's certainly more stable than the PJSUA approach so... fair enough.</pre>
<br />
<p>- Matt Jordan</p>
<br />
<p>On May 20th, 2014, 1:37 p.m. CDT, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Joshua Colp.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated May 20, 2014, 1:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23641">ASTERISK-23641</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This reworks a significant portion of the ARI attended transfer test to avoid dependence on pjsua since it has the tendency to cause sporadic (and sometimes consistent) test failures. The reworked test uses SIPp with 3PCC to manage the transfer scenario.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensured that the test was operating as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml <span style="color: grey">(5043)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referer.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referee.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py <span style="color: grey">(5043)</span></li>
<li>asterisk/trunk/contrib/sipp/transfer/referer.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/contrib/sipp/transfer/referee.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/contrib/sipp/table_of_contents <span style="color: grey">(5043)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3525/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>