[asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

Matt Jordan reviewboard at asterisk.org
Tue May 20 12:34:08 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3525/#review11922
-----------------------------------------------------------


I may be a bit dense on this, but I'm still confused as to what legs are getting transferred in this scenario.

You have two SIPp scenarios that are actually doing the REFER request and some portion of the attended transfer. Where are the other two call legs? If they are part of an already established Asterisk channel, which ones are getting replaced? Or are they doing the replacing?

A diagram would be _very_ helpful.


asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py
<https://reviewboard.asterisk.org/r/3525/#comment21798>

    Blobs


- Matt Jordan


On May 20, 2014, 9:32 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3525/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 9:32 a.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-23641
>     https://issues.asterisk.org/jira/browse/ASTERISK-23641
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This reworks a significant portion of the ARI attended transfer test to avoid dependence on pjsua since it has the tendency to cause sporadic (and sometimes consistent) test failures. The reworked test uses SIPp with 3PCC to manage the transfer scenario.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml 5043 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referer.xml PRE-CREATION 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referee.xml PRE-CREATION 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py 5043 
>   asterisk/trunk/contrib/sipp/transfer/referer.xml PRE-CREATION 
>   asterisk/trunk/contrib/sipp/transfer/referee.xml PRE-CREATION 
>   asterisk/trunk/contrib/sipp/table_of_contents 5043 
> 
> Diff: https://reviewboard.asterisk.org/r/3525/diff/
> 
> 
> Testing
> -------
> 
> Ensured that the test was operating as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140520/8ddc5573/attachment.html>


More information about the asterisk-dev mailing list