<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3525/">https://reviewboard.asterisk.org/r/3525/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I may be a bit dense on this, but I'm still confused as to what legs are getting transferred in this scenario.
You have two SIPp scenarios that are actually doing the REFER request and some portion of the attended transfer. Where are the other two call legs? If they are part of an already established Asterisk channel, which ones are getting replaced? Or are they doing the replacing?
A diagram would be _very_ helpful.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3525/diff/4/?file=58675#file58675line48" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sipp_referer</span> <span class="o">=</span> <span class="n">SIPpScenario</span><span class="p">(</span><span class="n">test_object</span><span class="o">.</span><span class="n">test_name</span><span class="p">,</span><span class="ew"> </span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">{</span><span class="s">'scenario'</span><span class="p">:</span><span class="s">'referer.xml'</span><span class="p">,</span> <span class="s">'-p'</span><span class="p">:</span><span class="s">'5065'</span><span class="p">,</span> <span class="s">'-3pcc'</span><span class="p">:</span><span class="s">'127.0.0.1:5064'</span><span class="p">},</span> <span class="n">target</span><span class="o">=</span><span class="s">'127.0.0.1'</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sipp_referee</span> <span class="o">=</span> <span class="n">SIPpScenario</span><span class="p">(</span><span class="n">test_object</span><span class="o">.</span><span class="n">test_name</span><span class="p">,</span><span class="ew"> </span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">{</span><span class="s">'scenario'</span><span class="p">:</span><span class="s">'referee.xml'</span><span class="p">,</span> <span class="s">'-p'</span><span class="p">:</span><span class="s">'5066'</span><span class="p">,</span> <span class="s">'-3pcc'</span><span class="p">:</span><span class="s">'127.0.0.1:5064'</span><span class="p">},</span> <span class="n">target</span><span class="o">=</span><span class="s">'127.0.0.1'</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Blobs</pre>
</div>
<br />
<p>- Matt Jordan</p>
<br />
<p>On May 20th, 2014, 9:32 a.m. CDT, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Joshua Colp.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated May 20, 2014, 9:32 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23641">ASTERISK-23641</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This reworks a significant portion of the ARI attended transfer test to avoid dependence on pjsua since it has the tendency to cause sporadic (and sometimes consistent) test failures. The reworked test uses SIPp with 3PCC to manage the transfer scenario.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensured that the test was operating as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml <span style="color: grey">(5043)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referer.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referee.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py <span style="color: grey">(5043)</span></li>
<li>asterisk/trunk/contrib/sipp/transfer/referer.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/contrib/sipp/transfer/referee.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/contrib/sipp/table_of_contents <span style="color: grey">(5043)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3525/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>