[asterisk-dev] [Code Review] 3534: Dahdi Dialtone detection regression

[one47]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3534/
-----------------------------------------------------------

(Updated May 16, 2014, 3:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 414067


Repository: Asterisk


Description
-------

Regression probably introduced when chan_dahdi was refactored in Asterisk 1.8. If waitfordialtone=nnn is enabled in chan_dahdi.conf, the dialtone is never detected. Once that is fixed, the dial still did not proceed. Patch attached to 1) Allow dsp to operate early enough to detect the dialtone if required 2) test the right variable to determine that dialtone has been detected.


Diffs
-----

  /tags/1.8.27.0/channels/chan_dahdi.c 413786 

Diff: https://reviewboard.asterisk.org/r/3534/diff/


Testing
-------

Dial using Sangoma Analogue card before and after patch, with waitfordialtone=3000 set.


Thanks,

one47

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140516/91579488/attachment.html>