[asterisk-dev] [Code Review] 3534: Dahdi Dialtone detection regression

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3534/#review11909
-----------------------------------------------------------

Ship it!


Ship It!

- rmudgett


On May 13, 2014, 6:11 a.m., one47 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3534/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 6:11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Regression probably introduced when chan_dahdi was refactored in Asterisk 1.8. If waitfordialtone=nnn is enabled in chan_dahdi.conf, the dialtone is never detected. Once that is fixed, the dial still did not proceed. Patch attached to 1) Allow dsp to operate early enough to detect the dialtone if required 2) test the right variable to determine that dialtone has been detected.
> 
> 
> Diffs
> -----
> 
>   /tags/1.8.27.0/channels/chan_dahdi.c 413786 
> 
> Diff: https://reviewboard.asterisk.org/r/3534/diff/
> 
> 
> Testing
> -------
> 
> Dial using Sangoma Analogue card before and after patch, with waitfordialtone=3000 set.
> 
> 
> Thanks,
> 
> one47
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140516/0a83f3a4/attachment.html>