[asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

[Joshua Colp]

> On May 8, 2014, 5:37 p.m., Matt Jordan wrote:
> > /team/group/media_formats-reviewed/channels/chan_mgcp.c, line 2600
> > <https://reviewboard.asterisk.org/r/3388/diff/2/?file=58249#file58249line2600>
> >
> >     I'd declare these on separate lines. Just a thought.

Done.


> On May 8, 2014, 5:37 p.m., Matt Jordan wrote:
> > /team/group/media_formats-reviewed/channels/chan_mgcp.c, line 2620
> > <https://reviewboard.asterisk.org/r/3388/diff/2/?file=58249#file58249line2620>
> >
> >     I enjoy this comment, because I have no reference for what it means... but you've kept the comment. Excellent.

History! SB5120E is actually a cable modem, SB = surfboard.


> On May 8, 2014, 5:37 p.m., Matt Jordan wrote:
> > /team/group/media_formats-reviewed/channels/chan_skinny.c, lines 4079-4097
> > <https://reviewboard.asterisk.org/r/3388/diff/2/?file=58250#file58250line4079>
> >
> >     I'm not sure we can just remove this from chan_skinny :-)
> >     
> >     If it's not currently possible to print out the codec preference order in some fashion, we should at least put in a BUGBUG to come back and add this when there's an API call for it.

Formats are stored in preference order and are returned in preference order, which means anything that iterates (including the function which turns it into a string) is in preference order already.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3388/#review11853
-----------------------------------------------------------


On May 5, 2014, 11:11 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3388/
> -----------------------------------------------------------
> 
> (Updated May 5, 2014, 11:11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This moves the chan_mgcp, chan_unistim, and chan_skinny modules over to the media formats API.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed/include/asterisk/format_cache.h 413300 
>   /team/group/media_formats-reviewed/channels/chan_unistim.c 413300 
>   /team/group/media_formats-reviewed/channels/chan_skinny.c 413300 
>   /team/group/media_formats-reviewed/channels/chan_mgcp.c 413300 
> 
> Diff: https://reviewboard.asterisk.org/r/3388/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140510/c02a5dd1/attachment-0001.html>