[asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3388/#review11855
-----------------------------------------------------------



/team/group/media_formats-reviewed/channels/chan_mgcp.c
<https://reviewboard.asterisk.org/r/3388/#comment21728>

    Problem from old code: 'global_capability' needs to be released for the module load failure paths.  As well as 'mgcp_tech.capabilities'



/team/group/media_formats-reviewed/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/3388/#comment21731>

    bugbug.



/team/group/media_formats-reviewed/channels/chan_unistim.c
<https://reviewboard.asterisk.org/r/3388/#comment21734>

    I think these need to be moved to be under the 'buffed_failed' tag.  A couple of paths goto 'buff_failed', but need items released.


- Kevin Harwell


On May 5, 2014, 6:11 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3388/
> -----------------------------------------------------------
> 
> (Updated May 5, 2014, 6:11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This moves the chan_mgcp, chan_unistim, and chan_skinny modules over to the media formats API.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed/include/asterisk/format_cache.h 413300 
>   /team/group/media_formats-reviewed/channels/chan_unistim.c 413300 
>   /team/group/media_formats-reviewed/channels/chan_skinny.c 413300 
>   /team/group/media_formats-reviewed/channels/chan_mgcp.c 413300 
> 
> Diff: https://reviewboard.asterisk.org/r/3388/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140508/2ddb3f08/attachment-0001.html>