[asterisk-dev] [Code Review] 3286: testsuite: chan_pjsip ice crash test for ASTERISK-22911

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3286/#review11109
-----------------------------------------------------------



/asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/3286/#comment20766>

    What is this user event here for?



/asterisk/trunk/tests/channels/pjsip/hold_ice/sipp/phone_B.xml
<https://reviewboard.asterisk.org/r/3286/#comment20768>

    Placing a pause between two <recv> blocks doesn't make much sense. It can be removed.



/asterisk/trunk/tests/channels/pjsip/hold_ice/test-config.yaml
<https://reviewboard.asterisk.org/r/3286/#comment20770>

    s/crash in detailed/crash detailed/



/asterisk/trunk/tests/channels/pjsip/hold_ice/test-config.yaml
<https://reviewboard.asterisk.org/r/3286/#comment20771>

    s/crash in/crash/


- Mark Michelson


On March 6, 2014, 5:44 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3286/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 5:44 p.m.)
> 
> 
> Review request for Asterisk Developers, Joshua Colp, Kevin Harwell, and Matt Jordan.
> 
> 
> Bugs: ASTERISK-22911
>     https://issues.asterisk.org/jira/browse/ASTERISK-22911
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Performs the same basic test as https://reviewboard.asterisk.org/r/3255/, but uses chan_pjsip for the channel driver.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/tests.yaml 4726 
>   /asterisk/trunk/tests/channels/pjsip/hold_ice/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/hold_ice/sipp/phone_B.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/hold_ice/sipp/phone_A.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/hold_ice/sipp/inject.csv PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/hold_ice/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/rtp.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3286/diff/
> 
> 
> Testing
> -------
> 
> Tested against Asterisk 12 revision before kharwell's initial patch for clearing candidates was put in, got the expected crash.  The patch also fails without the current patch from https://reviewboard.asterisk.org/r/3275/
> 
> Everything works basically the same way as the chan_sip equivalent test does.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140306/7fc8941b/attachment-0001.html>