[asterisk-dev] [Code Review] 3286: testsuite: chan_pjsip ice crash test for ASTERISK-22911

Jonathan Rose reviewboard at asterisk.org
Thu Mar 6 11:44:59 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3286/
-----------------------------------------------------------

(Updated March 6, 2014, 11:44 a.m.)


Review request for Asterisk Developers, Joshua Colp, Kevin Harwell, and Matt Jordan.


Changes
-------

Address most of the same comments from 3255


Bugs: ASTERISK-22911
    https://issues.asterisk.org/jira/browse/ASTERISK-22911


Repository: testsuite


Description
-------

Performs the same basic test as https://reviewboard.asterisk.org/r/3255/, but uses chan_pjsip for the channel driver.


Diffs (updated)
-----

  /asterisk/trunk/tests/channels/pjsip/tests.yaml 4726 
  /asterisk/trunk/tests/channels/pjsip/hold_ice/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/hold_ice/sipp/phone_B.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/hold_ice/sipp/phone_A.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/hold_ice/sipp/inject.csv PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/hold_ice/run-test PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/rtp.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/extensions.conf PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3286/diff/


Testing
-------

Tested against Asterisk 12 revision before kharwell's initial patch for clearing candidates was put in, got the expected crash.  The patch also fails without the current patch from https://reviewboard.asterisk.org/r/3275/

Everything works basically the same way as the chan_sip equivalent test does.


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140306/a79381f0/attachment-0001.html>


More information about the asterisk-dev mailing list