[asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

[Joshua Colp]

> On June 30, 2014, 1:12 p.m., Matt Jordan wrote:
> > /branches/12/res/res_pjsip_sdp_rtp.c, lines 541-545
> > <https://reviewboard.asterisk.org/r/3686/diff/1/?file=61142#file61142line541>
> >
> >     That seems like an odd setting return here.
> >     
> >     Why wouldn't this return AST_SIP_MEDIA_ENCRYPT_DTLS?

I've made it so that the incoming encryption is returned.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3686/#review12389
-----------------------------------------------------------


On June 28, 2014, 1:35 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3686/
> -----------------------------------------------------------
> 
> (Updated June 28, 2014, 1:35 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change requires the work for 11 but the merge up is pretty much clean, so this review only includes the PJSIP parts.
> 
> SHA-256 support has been added as has two options. One option controls the outgoing transport in SDP offers and the other controls the transport in SDP answers.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_sdp_rtp.c 417479 
>   /branches/12/res/res_pjsip/pjsip_configuration.c 417479 
>   /branches/12/res/res_pjsip.c 417479 
>   /branches/12/include/asterisk/res_pjsip_session.h 417479 
>   /branches/12/include/asterisk/res_pjsip.h 417479 
> 
> Diff: https://reviewboard.asterisk.org/r/3686/diff/
> 
> 
> Testing
> -------
> 
> Calling.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140630/3a2fa9ba/attachment-0001.html>