[asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3686/#review12389
-----------------------------------------------------------



/branches/12/res/res_pjsip.c
<https://reviewboard.asterisk.org/r/3686/#comment22594>

    Yay new options!
    
    That means we need an update to UPGRADE, as well as an update to the Alembic scripts for these options.



/branches/12/res/res_pjsip.c
<https://reviewboard.asterisk.org/r/3686/#comment22596>

    I'd change the synopsis slightly, since this will apply beyond DTLS streams as well. How about:
    
    "Determines whether res_pjsip will use and enforce usage of AVP, regardless of the RTP profile in use for this endpoint"
    
    In the full description, you can still mention DTLS as one place that this applies.



/branches/12/res/res_pjsip.c
<https://reviewboard.asterisk.org/r/3686/#comment22593>

    Red blob



/branches/12/res/res_pjsip_sdp_rtp.c
<https://reviewboard.asterisk.org/r/3686/#comment22597>

    If any of these fail, that is, the attributes are not in the SDP, should we bail out of attempting to set up ICE?



/branches/12/res/res_pjsip_sdp_rtp.c
<https://reviewboard.asterisk.org/r/3686/#comment22598>

    That seems like an odd setting return here.
    
    Why wouldn't this return AST_SIP_MEDIA_ENCRYPT_DTLS?


- Matt Jordan


On June 28, 2014, 8:35 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3686/
> -----------------------------------------------------------
> 
> (Updated June 28, 2014, 8:35 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change requires the work for 11 but the merge up is pretty much clean, so this review only includes the PJSIP parts.
> 
> SHA-256 support has been added as has two options. One option controls the outgoing transport in SDP offers and the other controls the transport in SDP answers.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_sdp_rtp.c 417479 
>   /branches/12/res/res_pjsip/pjsip_configuration.c 417479 
>   /branches/12/res/res_pjsip.c 417479 
>   /branches/12/include/asterisk/res_pjsip_session.h 417479 
>   /branches/12/include/asterisk/res_pjsip.h 417479 
> 
> Diff: https://reviewboard.asterisk.org/r/3686/diff/
> 
> 
> Testing
> -------
> 
> Calling.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140630/22312df7/attachment-0001.html>