[asterisk-dev] [Code Review] 3670: ao2_container node object ignores REF_DEBUG in all places except one

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3670/
-----------------------------------------------------------

(Updated June 25, 2014, 1:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers, George Joseph, Matt Jordan, and rmudgett.


Changes
-------

Committed in revision 417212


Bugs: ASTERISK-23922
    https://issues.asterisk.org/jira/browse/ASTERISK-23922


Repository: Asterisk


Description
-------

Almost every reference operation against container node's uses __ao2_alloc or __ao2_ref, thereby preventing ref logging for the nodes.  One node reference is released with ao2_t_ref, causing refcounter.py to falsely report skews and leaks for many nodes.


Diffs
-----

  /branches/12/main/astobj2_container.c 417180 

Diff: https://reviewboard.asterisk.org/r/3670/diff/


Testing
-------

Tested against media_formats-reviewed-trunk (that's where I found the issue).  Verified no container nodes appeared in the REF_DEBUG.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140625/bfb0a6aa/attachment.html>