[asterisk-dev] [Code Review] 3670: ao2_container node object ignores REF_DEBUG in all places except one

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3670/#review12303
-----------------------------------------------------------

Ship it!


Minor nit that you could ignore. :)


/branches/12/main/astobj2_container.c
<https://reviewboard.asterisk.org/r/3670/#comment22475>

    Add comment that was there previously:
    /* Unref the node from the container. */


- rmudgett


On June 24, 2014, 1:28 a.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3670/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 1:28 a.m.)
> 
> 
> Review request for Asterisk Developers, George Joseph, Matt Jordan, and rmudgett.
> 
> 
> Bugs: ASTERISK-23922
>     https://issues.asterisk.org/jira/browse/ASTERISK-23922
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Almost every reference operation against container node's uses __ao2_alloc or __ao2_ref, thereby preventing ref logging for the nodes.  One node reference is released with ao2_t_ref, causing refcounter.py to falsely report skews and leaks for many nodes.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/astobj2_container.c 417180 
> 
> Diff: https://reviewboard.asterisk.org/r/3670/diff/
> 
> 
> Testing
> -------
> 
> Tested against media_formats-reviewed-trunk (that's where I found the issue).  Verified no container nodes appeared in the REF_DEBUG.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140624/1191079e/attachment.html>