[asterisk-dev] [Code Review] 3669: chan_sip: Fix handling of "From" headers longer than 256 characters

Corey Farrell reviewboard at asterisk.org
Wed Jun 25 01:42:17 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3669/
-----------------------------------------------------------

(Updated June 25, 2014, 2:42 a.m.)


Review request for Asterisk Developers.


Changes
-------

Fix provided by Walter (thanks!)


Bugs: ASTERISK-23790
    https://issues.asterisk.org/jira/browse/ASTERISK-23790


Repository: Asterisk


Description
-------

>From headers were processed using a 256 character buffer on the stack.  This change replaces that with a heap allocation by ast_strdup.

The only difference for the 11+ patch is that get_header was renamed to sip_get_header.


Diffs (updated)
-----

  /branches/1.8/channels/chan_sip.c 417180 

Diff: https://reviewboard.asterisk.org/r/3669/diff/


Testing
-------

Tested by uniken1 (reporter).


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140625/c4649f49/attachment.html>


More information about the asterisk-dev mailing list