[asterisk-dev] [Code Review] 3669: chan_sip: Fix handling of "From" headers longer than 256 characters

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3669/#review12292
-----------------------------------------------------------


chan_sip :(


/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3669/#comment22454>

    You've just freed what 'of' still points to.


See the r3 patch on the issue.

- wdoekes


On June 24, 2014, 5:50 a.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3669/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 5:50 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23790
>     https://issues.asterisk.org/jira/browse/ASTERISK-23790
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> From headers were processed using a 256 character buffer on the stack.  This change replaces that with a heap allocation by ast_strdup.
> 
> The only difference for the 11+ patch is that get_header was renamed to sip_get_header.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 417180 
> 
> Diff: https://reviewboard.asterisk.org/r/3669/diff/
> 
> 
> Testing
> -------
> 
> Tested by uniken1 (reporter).
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140624/bf2d2888/attachment.html>