[asterisk-dev] [Code Review] 3621: documentation: features.conf.sample is unclear as to which parking options apply globally to all parking lots (1.8)

[rnewton]

> On June 18, 2014, 3:54 a.m., rmudgett wrote:
> > /branches/1.8/configs/features.conf.sample, line 23
> > <https://reviewboard.asterisk.org/r/3621/diff/2/?file=59773#file59773line23>
> >
> >     You might want to have a standard default format for the options in this file for consistency.  You likely should put the default note on its own line.

We've already done some cleanup here going beyond the issue at hand, and doing this one looks to be pretty tedious considering most of the default notes have different formats throughout the file. I'm going to drop this one for now. My goal was just to make it more clear which options were global and which were per parking lot.


> On June 18, 2014, 3:54 a.m., rmudgett wrote:
> > /branches/1.8/configs/features.conf.sample, line 99
> > <https://reviewboard.asterisk.org/r/3621/diff/2/?file=59773#file59773line99>
> >
> >     These lines could be removed since you have grouped them in the per parking lot section.

This was quick, also removed the "operates on all parking lots" lines for the same reason. Plus added a note under the "Parking Options" heading.

; These options apply to all parking lots, including the default lot defined in                                      
; the general context.  


- rnewton


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3621/#review12181
-----------------------------------------------------------


On June 17, 2014, 11:46 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3621/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 11:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23667
>     https://issues.asterisk.org/jira/browse/ASTERISK-23667
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The features.conf sample can be a bit confusing about what parking options can be set only in the general context, or both in the general context (for the default parking lot) and in other parking lot contexts. A bug was filed due to confusion and a little googling will show lots of other confused users.
> 
> Despite some comments on the individual options, it still reads in a confusing way. In this patch I separate out those options with some headings in to attempt a better layout. I went ahead and modified other headings in the file, or added them to facilitate better visual scanning.
> 
> Change to 11: https://reviewboard.asterisk.org/r/3622/
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/configs/features.conf.sample 416556 
> 
> Diff: https://reviewboard.asterisk.org/r/3621/diff/
> 
> 
> Testing
> -------
> 
> Sample file update, doesn't affect configuration. Only rearranged text, no addition or removal of options or contexts. So, no testing, other than looking at it!
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140619/c65eddbd/attachment.html>