[asterisk-dev] [Code Review] 3621: documentation: features.conf.sample is unclear as to which parking options apply globally to all parking lots (1.8)

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3621/#review12181
-----------------------------------------------------------



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22237>

    You might want to have a standard default format for the options in this file for consistency.  You likely should put the default note on its own line.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22238>

    These lines could be removed since you have grouped them in the per parking lot section.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22235>

    blob



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22236>

    Recheck the default range I gave earlier.  It is not 701-720.
    
    Please double check that the stated option defaults are as I put in the earlier review since I got them out of the code.


- rmudgett


On June 17, 2014, 6:46 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3621/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 6:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23667
>     https://issues.asterisk.org/jira/browse/ASTERISK-23667
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The features.conf sample can be a bit confusing about what parking options can be set only in the general context, or both in the general context (for the default parking lot) and in other parking lot contexts. A bug was filed due to confusion and a little googling will show lots of other confused users.
> 
> Despite some comments on the individual options, it still reads in a confusing way. In this patch I separate out those options with some headings in to attempt a better layout. I went ahead and modified other headings in the file, or added them to facilitate better visual scanning.
> 
> Change to 11: https://reviewboard.asterisk.org/r/3622/
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/configs/features.conf.sample 416556 
> 
> Diff: https://reviewboard.asterisk.org/r/3621/diff/
> 
> 
> Testing
> -------
> 
> Sample file update, doesn't affect configuration. Only rearranged text, no addition or removal of options or contexts. So, no testing, other than looking at it!
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140618/dd41e85e/attachment.html>