[asterisk-dev] [Code Review] 3621: documentation: features.conf.sample is unclear as to which parking options apply globally to all parking lots (1.8)

[rnewton]

> On June 13, 2014, 10:46 p.m., rmudgett wrote:
> > /branches/1.8/configs/features.conf.sample, lines 154-155
> > <https://reviewboard.asterisk.org/r/3621/diff/1/?file=59658#file59658line154>
> >
> >     The information in this note for parkext and parkpos should be put with the descriptions instead of here.

I added those notes to the option descriptions *and* left the note in the original spot as well. It is a good reminder to a user who scrolls right to the example definition and doesn't read the individual option descriptions first.


> On June 13, 2014, 10:46 p.m., rmudgett wrote:
> > /branches/1.8/configs/features.conf.sample, line 20
> > <https://reviewboard.asterisk.org/r/3621/diff/1/?file=59658#file59658line20>
> >
> >     You should group these global options to the various subgroups with a blank line separating the groups:
> >     pickup
> >     transfer
> >     transfer-sounds
> >     atxfer
> >     parking

I used the groups,  Pickup Options, Transfer Options and Parking Options. I didn't feel there was enough options to justify sub-groups beyond that.  Thanks!


- rnewton


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3621/#review12153
-----------------------------------------------------------


On June 13, 2014, 8:44 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3621/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 8:44 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23667
>     https://issues.asterisk.org/jira/browse/ASTERISK-23667
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The features.conf sample can be a bit confusing about what parking options can be set only in the general context, or both in the general context (for the default parking lot) and in other parking lot contexts. A bug was filed due to confusion and a little googling will show lots of other confused users.
> 
> Despite some comments on the individual options, it still reads in a confusing way. In this patch I separate out those options with some headings in to attempt a better layout. I went ahead and modified other headings in the file, or added them to facilitate better visual scanning.
> 
> Change to 11: https://reviewboard.asterisk.org/r/3622/
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/configs/features.conf.sample 416208 
> 
> Diff: https://reviewboard.asterisk.org/r/3621/diff/
> 
> 
> Testing
> -------
> 
> Sample file update, doesn't affect configuration. Only rearranged text, no addition or removal of options or contexts. So, no testing, other than looking at it!
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140617/23640611/attachment.html>