[asterisk-dev] [Code Review] 3621: documentation: features.conf.sample is unclear as to which parking options apply globally to all parking lots (1.8)

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3621/#review12153
-----------------------------------------------------------



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22190>

    You should group these global options to the various subgroups with a blank line separating the groups:
    pickup
    transfer
    transfer-sounds
    atxfer
    parking



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22187>

    ...will apply only to the default parking lot.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22176>

    Default is 700 for all parkinglots.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22182>

    Default is no for all parkinglots.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22174>

    Default parkinglot defaults to 701-750.
    Non-default parkinglots must spcify values.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22175>

    Default parkinglot defaults to "parkedcalls".
    Non-default parkinglots must spcify a context.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22177>

    Default is no for all parkinglots.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22178>

    Default is 45 for all parkinglots.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22179>

    Default is no for all parkinglots.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22180>

    Default is no for all parkinglots.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22181>

    Default is no for all parkinglots.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22183>

    Default is no for all parkinglots.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22184>

    Default is "first" for all parkinglots.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22186>

    Default parkinglot defaults to "default".
    Non-default parkinglots don't spcify a class so the class is picked by the channel put on hold which is the default class by default.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22189>

    Example non-default parkinglot definition.



/branches/1.8/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/3621/#comment22188>

    The information in this note for parkext and parkpos should be put with the descriptions instead of here.


- rmudgett


On June 13, 2014, 3:44 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3621/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 3:44 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23667
>     https://issues.asterisk.org/jira/browse/ASTERISK-23667
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The features.conf sample can be a bit confusing about what parking options can be set only in the general context, or both in the general context (for the default parking lot) and in other parking lot contexts. A bug was filed due to confusion and a little googling will show lots of other confused users.
> 
> Despite some comments on the individual options, it still reads in a confusing way. In this patch I separate out those options with some headings in to attempt a better layout. I went ahead and modified other headings in the file, or added them to facilitate better visual scanning.
> 
> Change to 11: https://reviewboard.asterisk.org/r/3622/
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/configs/features.conf.sample 416208 
> 
> Diff: https://reviewboard.asterisk.org/r/3621/diff/
> 
> 
> Testing
> -------
> 
> Sample file update, doesn't affect configuration. Only rearranged text, no addition or removal of options or contexts. So, no testing, other than looking at it!
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140613/d4c318f2/attachment-0001.html>