[asterisk-dev] [Code Review] 3593: astobj2: Additional refactoring to push impl specific code down into the impls.

[George Joseph]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3593/
-----------------------------------------------------------

(Updated June 6, 2014, 1:49 p.m.)


Review request for Asterisk Developers and rmudgett.


Changes
-------

Addressed Richard's comments concerning sort_fn being a prereq for a container integrity check.

However...  Removing the sort_fn check is highlighting issues, mostly in main/format, that are causing lots of integrity check failed error messages to be printed to the console.  The issues are pre-existing and all test framework tests pass, it's just that there are now errors being printed for them.


Repository: Asterisk


Description
-------

Move some implementation specific code from astobj2_container.c into astobj2_hash.c and astobj2_rbtree.c.  This completely removes the need for astobj2_container to switch on RTTI and it no longer has any knowledge of the implementation details.  The RTTI itself is no longer needed but I don't want to remove it until weak reference containers are added in case I need it back again.  If not, I'll remove it then.


Diffs (updated)
-----

  branches/12/main/astobj2_rbtree.c 415336 
  branches/12/main/astobj2_hash.c 415336 
  branches/12/main/astobj2_container_private.h 415336 
  branches/12/main/astobj2_container.c 415336 

Diff: https://reviewboard.asterisk.org/r/3593/diff/


Testing
-------

Ran all the test framework tests plus the "astobj2 test" test.
Ran testsuite tests/channels/pjsip.


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140606/80a43535/attachment.html>