[asterisk-dev] [Code Review] 3593: astobj2: Additional refactoring to push impl specific code down into the impls.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3593/#review12084
-----------------------------------------------------------



branches/12/main/astobj2_hash.c
<https://reviewboard.asterisk.org/r/3593/#comment22098>

    You can actually put this integrity check back into the common code without any RTTI conditions.  The exception for the hash container is no longer true because of the -r381427 fix by seanbright.



branches/12/main/astobj2_hash.c
<https://reviewboard.asterisk.org/r/3593/#comment22099>

    You can actually put this integrity check back into the common code without any RTTI conditions.  The exception for the hash container is no longer true because of the -r381427 fix by seanbright.



branches/12/main/astobj2_rbtree.c
<https://reviewboard.asterisk.org/r/3593/#comment22100>

    You can actually put this integrity check back into the common code without any RTTI conditions.  The exception for the hash container is no longer true because of the -r381427 fix by seanbright.



branches/12/main/astobj2_rbtree.c
<https://reviewboard.asterisk.org/r/3593/#comment22101>

    You can actually put this integrity check back into the common code without any RTTI conditions.  The exception for the hash container is no longer true because of the -r381427 fix by seanbright.


- rmudgett


On June 6, 2014, 11:16 a.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3593/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 11:16 a.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Move some implementation specific code from astobj2_container.c into astobj2_hash.c and astobj2_rbtree.c.  This completely removes the need for astobj2_container to switch on RTTI and it no longer has any knowledge of the implementation details.  The RTTI itself is no longer needed but I don't want to remove it until weak reference containers are added in case I need it back again.  If not, I'll remove it then.
> 
> 
> Diffs
> -----
> 
>   branches/12/main/astobj2_rbtree.c 415336 
>   branches/12/main/astobj2_hash.c 415336 
>   branches/12/main/astobj2_container_private.h 415336 
>   branches/12/main/astobj2_container.c 415336 
> 
> Diff: https://reviewboard.asterisk.org/r/3593/diff/
> 
> 
> Testing
> -------
> 
> Ran all the test framework tests plus the "astobj2 test" test.
> Ran testsuite tests/channels/pjsip.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140606/b34ef0fc/attachment-0001.html>