[asterisk-dev] [Code Review] 3582: Confbridge Message when Muting a WaitMarked User is Confusing

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3582/#review12041
-----------------------------------------------------------

Ship it!


Other than the minor comment style nit pick this looks good.


/branches/12/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/3582/#comment21980>

    Per guidelines the C++ comment style is not to be used.  I'd also move the comment to the then block.


- rmudgett


On June 3, 2014, 7:01 p.m., Andrew Nagy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3582/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 7:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In confbridge when attempting to mute a user who is WaitMarked for Leader wait the message from the CLI comes back as "No channel named 'PJSIP/1000-00000015' found in conference 4000" which is confusing because the channel is in the conference it's just not in the active list.
> 
> My proposed solution is the patch attached to this file where I return a message to both the CLI and the AMI if the user is wait marked.
> 
> 
> Diffs
> -----
> 
>   /branches/12/apps/app_confbridge.c 415059 
> 
> Diff: https://reviewboard.asterisk.org/r/3582/diff/
> 
> 
> Testing
> -------
> 
> Tested Adding marked users and attempting to mute them, then tested with an invalid channel and finally tested that regular muting still worked.
> 
> 
> Thanks,
> 
> Andrew Nagy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140604/972ce760/attachment.html>