[asterisk-dev] [Code Review] 3582: Confbridge Message when Muting a WaitMarked User is Confusing

[Andrew Nagy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3582/
-----------------------------------------------------------

(Updated June 3, 2014, 5:01 p.m.)


Review request for Asterisk Developers.


Changes
-------

Thanks to tips from @rmudgett the newest diff reduces the changed lines to 8


Repository: Asterisk


Description
-------

In confbridge when attempting to mute a user who is WaitMarked for Leader wait the message from the CLI comes back as "No channel named 'PJSIP/1000-00000015' found in conference 4000" which is confusing because the channel is in the conference it's just not in the active list.

My proposed solution is the patch attached to this file where I return a message to both the CLI and the AMI if the user is wait marked.


Diffs (updated)
-----

  /branches/12/apps/app_confbridge.c 415059 

Diff: https://reviewboard.asterisk.org/r/3582/diff/


Testing
-------

Tested Adding marked users and attempting to mute them, then tested with an invalid channel and finally tested that regular muting still worked.


Thanks,

Andrew Nagy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140604/89f2a432/attachment.html>