[asterisk-dev] [Code Review] 3580: Handle 183 without SDP - don't always convert to ringing

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3580/#review12033
-----------------------------------------------------------



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3580/#comment21977>

    This "workaround" has probably caused more problems than it solved.
    
    Unfortunately, I don't think this patch will always work.
    
    If the SDP we receive in the first 183 contains a "sendonly" attribute, the remote address on the RTP instance will be 0. This will cause this code to treat a subsequent 183 as Ringing, even though we've received an SDP that negotiates an audio media stream.
    
    As much as I hate 'levers' to control behavior, this may be a situation where it would be appropriate to have a configuration setting to either treat a 183 without an SDP as Ringing or not.
    
    It could default to the existing behavior in 1.8-12; we could change the default to honoring the 183 in 13+.


- Matt Jordan


On June 3, 2014, 9:34 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3580/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 9:34 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-15852
>     https://issues.asterisk.org/jira/browse/ASTERISK-15852
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Lync sends the first 183 with SDP using prack. Following 183s have no SDP. The current code treats follow-ups as RINGING, which is a bug.
> 
> Red blobs are a bonus in the review, but will not be offered in commit.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 414989 
> 
> Diff: https://reviewboard.asterisk.org/r/3580/diff/
> 
> 
> Testing
> -------
> 
> Just a few thousand calls. That's all.
> 
> 
> Thanks,
> 
> Olle E Johansson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140603/383cc893/attachment.html>