[asterisk-dev] [Code Review] 3580: Handle 183 without SDP - don't always convert to ringing

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3580/
-----------------------------------------------------------

(Updated June 3, 2014, 9:34 a.m.)


Review request for Asterisk Developers.


Changes
-------

Added bug ASTERISK-15852 (original issue for the 183 -> 180 conversion)


Bugs: ASTERISK-15852
    https://issues.asterisk.org/jira/browse/ASTERISK-15852


Repository: Asterisk


Description
-------

Lync sends the first 183 with SDP using prack. Following 183s have no SDP. The current code treats follow-ups as RINGING, which is a bug.

Red blobs are a bonus in the review, but will not be offered in commit.


Diffs
-----

  /branches/1.8/channels/chan_sip.c 414989 

Diff: https://reviewboard.asterisk.org/r/3580/diff/


Testing
-------

Just a few thousand calls. That's all.


Thanks,

Olle E Johansson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140603/edc00678/attachment-0001.html>