[asterisk-dev] [Code Review] 3832: testsuite: Accountcode propagation.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3832/
-----------------------------------------------------------

(Updated July 22, 2014, 8:13 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed review feedback including eliminating the Wait. :)


Bugs: AFS-65
    https://issues.asterisk.org/jira/browse/AFS-65


Repository: testsuite


Description
-------

New tests to check accountcode propagation with the new accouncode/peeracccount interaction.

* Made pluggable_modules.py Originator class and test_case.py
SimpleTestCase class call origination allow specifying the accountcode.

* Fix tests/cdr/sqlite3 to work with the new accountcode propagation rules.

* Add accountcode tag to existing tests doing something with accountcode.

Testsuite tests to go with https://reviewboard.asterisk.org/r/3601/


Diffs (updated)
-----

  /asterisk/trunk/tests/pbx/tests.yaml 5295 
  /asterisk/trunk/tests/pbx/accountcode/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/queue_peer_preserve/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/queue_peer_preserve/configs/ast1/queues.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/queue_peer_preserve/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/queue_peer_preserve/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/queue_peer_none/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/queue_peer_none/configs/ast1/queues.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/queue_peer_none/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/queue_peer_none/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/queue_none/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/queue_none/configs/ast1/queues.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/queue_none/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/queue_none/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/local_originate/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/local_originate/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/local_crossover_back/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/local_crossover_back/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/local_crossover/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/local_crossover/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_straight_override/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_straight_override/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_straight_override/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_straight_none/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_straight_none/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_straight_none/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_predial/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_predial/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_predial/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_peer_override/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_peer_override/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_peer_override/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_peer_none/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_peer_none/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_peer_none/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_none/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_none/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/pbx/accountcode/dial_none/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/cdr/sqlite3/test-config.yaml 5295 
  /asterisk/trunk/tests/cdr/console_dial_sip_transfer/test-config.yaml 5295 
  /asterisk/trunk/tests/cdr/console_dial_sip_congestion/test-config.yaml 5295 
  /asterisk/trunk/tests/cdr/console_dial_sip_busy/test-config.yaml 5295 
  /asterisk/trunk/tests/cdr/console_dial_sip_answer/test-config.yaml 5295 
  /asterisk/trunk/tests/cdr/cdr_unanswered_yes/test-config.yaml 5295 
  /asterisk/trunk/tests/cdr/cdr_properties/cdr_accountcode/test-config.yaml 5295 
  /asterisk/trunk/tests/cdr/cdr_properties/blind-transfer-accountcode/test-config.yaml 5295 
  /asterisk/trunk/tests/cdr/cdr_originate_sip_congestion_log/test-config.yaml 5295 
  /asterisk/trunk/tests/cdr/cdr_manipulation/console_fork_before_dial/test-config.yaml 5295 
  /asterisk/trunk/tests/cdr/cdr_manipulation/console_fork_after_busy_forward/test-config.yaml 5295 
  /asterisk/trunk/tests/cdr/cdr_manipulation/cdr_fork_end_time/test-config.yaml 5295 
  /asterisk/trunk/lib/python/asterisk/test_case.py 5295 
  /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5295 

Diff: https://reviewboard.asterisk.org/r/3832/diff/


Testing
-------

All accountcode tagged tests pass.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140723/334b8c89/attachment.html>