<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3832/">https://reviewboard.asterisk.org/r/3832/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated July 22, 2014, 8:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed review feedback including eliminating the Wait. :)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/AFS-65">AFS-65</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New tests to check accountcode propagation with the new accouncode/peeracccount interaction.
* Made pluggable_modules.py Originator class and test_case.py
SimpleTestCase class call origination allow specifying the accountcode.
* Fix tests/cdr/sqlite3 to work with the new accountcode propagation rules.
* Add accountcode tag to existing tests doing something with accountcode.
Testsuite tests to go with https://reviewboard.asterisk.org/r/3601/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All accountcode tagged tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/pbx/tests.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/queue_peer_preserve/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/queue_peer_preserve/configs/ast1/queues.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/queue_peer_preserve/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/queue_peer_preserve/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/queue_peer_none/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/queue_peer_none/configs/ast1/queues.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/queue_peer_none/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/queue_peer_none/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/queue_none/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/queue_none/configs/ast1/queues.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/queue_none/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/queue_none/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/local_originate/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/local_originate/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/local_crossover_back/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/local_crossover_back/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/local_crossover/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/local_crossover/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_straight_override/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_straight_override/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_straight_override/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_straight_none/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_straight_none/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_straight_none/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_predial/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_predial/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_predial/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_peer_override/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_peer_override/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_peer_override/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_peer_none/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_peer_none/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_peer_none/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_none/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_none/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/pbx/accountcode/dial_none/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/cdr/sqlite3/test-config.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/test-config.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/test-config.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/test-config.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/test-config.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_unanswered_yes/test-config.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_properties/cdr_accountcode/test-config.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_properties/blind-transfer-accountcode/test-config.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_originate_sip_congestion_log/test-config.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_manipulation/console_fork_before_dial/test-config.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_manipulation/console_fork_after_busy_forward/test-config.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_manipulation/cdr_fork_end_time/test-config.yaml <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/test_case.py <span style="color: grey">(5295)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/pluggable_modules.py <span style="color: grey">(5295)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3832/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>