[asterisk-dev] [Code Review] 3762: testsuite: Tests for endpoint subscription (nominal + basic off-nominal)

Matt Jordan reviewboard at asterisk.org
Tue Jul 22 11:26:52 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3762/
-----------------------------------------------------------

(Updated July 22, 2014, 11:26 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 5296


Bugs: ASTERISK-23692
    https://issues.asterisk.org/jira/browse/ASTERISK-23692


Repository: testsuite


Description
-------

This patch adds four tests:
* applications/subscribe-endpoint/nominal/resource - subscribe to a resource and verify that expected endpoint/channel events are received. Also ensures that we don't get stray endpoint messages from things we didn't subscribe to.
* applications/subscribe-endpoint/nominal/tech - subscribe to a technology and verify that expected endpoint/channel events are received. Again, we also make sure that we don't get stray endpoint messages for things we didn't subscribe to.
* applications/subscribe-endpoint/off-nominal/unknown_resource - make sure we get a 422 if we subscribe to a valid technology but invalid resource
* applications/subscribe-endpoint/off-nominal/unknown_tech - make sure we get a 422 if we subscribe to an invalid technology


Diffs
-----

  /asterisk/trunk/tests/rest_api/applications/tests.yaml 5237 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/subscriber.py PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/off-nominal/unknown_tech/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/off-nominal/unknown_tech/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/off-nominal/unknown_resource/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/off-nominal/unknown_resource/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/off-nominal/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast2/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast2/iax.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast2/http.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast1/iax.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast2/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast2/iax.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast2/http.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast1/iax.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/ari.py 5237 
  /asterisk/trunk/configs/ari.conf 5237 

Diff: https://reviewboard.asterisk.org/r/3762/diff/


Testing
-------

Tests pass with changes on r3760


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140722/79e4e2c2/attachment.html>


More information about the asterisk-dev mailing list