[asterisk-dev] [Code Review] 3762: testsuite: Tests for endpoint subscription (nominal + basic off-nominal)

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3762/#review12714
-----------------------------------------------------------

Ship it!



/asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/test-config.yaml
<https://reviewboard.asterisk.org/r/3762/#comment23001>

    Add pjsip and IAX2 tags as well.



/asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/test-config.yaml
<https://reviewboard.asterisk.org/r/3762/#comment23002>

    Same here.


- opticron


On July 12, 2014, 3:18 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3762/
> -----------------------------------------------------------
> 
> (Updated July 12, 2014, 3:18 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23692
>     https://issues.asterisk.org/jira/browse/ASTERISK-23692
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch adds four tests:
> * applications/subscribe-endpoint/nominal/resource - subscribe to a resource and verify that expected endpoint/channel events are received. Also ensures that we don't get stray endpoint messages from things we didn't subscribe to.
> * applications/subscribe-endpoint/nominal/tech - subscribe to a technology and verify that expected endpoint/channel events are received. Again, we also make sure that we don't get stray endpoint messages for things we didn't subscribe to.
> * applications/subscribe-endpoint/off-nominal/unknown_resource - make sure we get a 422 if we subscribe to a valid technology but invalid resource
> * applications/subscribe-endpoint/off-nominal/unknown_tech - make sure we get a 422 if we subscribe to an invalid technology
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/applications/tests.yaml 5237 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/subscriber.py PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/off-nominal/unknown_tech/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/off-nominal/unknown_tech/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/off-nominal/unknown_resource/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/off-nominal/unknown_resource/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/off-nominal/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast2/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast2/http.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast1/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/tech/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast2/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast2/http.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast1/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-endpoint/nominal/resource/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/ari.py 5237 
>   /asterisk/trunk/configs/ari.conf 5237 
> 
> Diff: https://reviewboard.asterisk.org/r/3762/diff/
> 
> 
> Testing
> -------
> 
> Tests pass with changes on r3760
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140717/ee7de6e0/attachment.html>