[asterisk-dev] [Code Review] 3754: media formats: fix ref leak on peer for mwi sub

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3754/#review12653
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On July 15, 2014, 9:59 a.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3754/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 9:59 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23959
>     https://issues.asterisk.org/jira/browse/ASTERISK-23959
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> To resolve circular reference, pass peer name to mwi_event_cb instead of link to peer with ref held.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed-trunk/channels/chan_sip.c 418631 
> 
> Diff: https://reviewboard.asterisk.org/r/3754/diff/
> 
> 
> Testing
> -------
> 
> Resolved ref leak according to REF_DEBUG, and tests clean under valgrind as well.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140715/e1c5a706/attachment.html>