[asterisk-dev] [Code Review] 3754: media formats: fix ref leak on peer for mwi sub

Scott Griepentrog reviewboard at asterisk.org
Tue Jul 15 09:59:58 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3754/
-----------------------------------------------------------

(Updated July 15, 2014, 9:59 a.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed issues.


Bugs: ASTERISK-23959
    https://issues.asterisk.org/jira/browse/ASTERISK-23959


Repository: Asterisk


Description
-------

To resolve circular reference, pass peer name to mwi_event_cb instead of link to peer with ref held.


Diffs (updated)
-----

  /team/group/media_formats-reviewed-trunk/channels/chan_sip.c 418631 

Diff: https://reviewboard.asterisk.org/r/3754/diff/


Testing
-------

Resolved ref leak according to REF_DEBUG, and tests clean under valgrind as well.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140715/324f1cfa/attachment.html>


More information about the asterisk-dev mailing list