[asterisk-dev] [Code Review] 3784: media formats: Correct PJSIP's outbound codec offers

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3784/#review12645
-----------------------------------------------------------

Ship it!


Please do make sure that a unit test gets written for this as well.

- Matt Jordan


On July 14, 2014, 2:21 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3784/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 2:21 p.m.)
> 
> 
> Review request for Asterisk Developers, Corey Farrell, Joshua Colp, and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This fixes the codecs that chan_pjsip offers on outbound call attempts. chan_pjsip will now offer the endpoint-configured codec preferences with requested formats replacing equivalent configured formats. Previously, chan_pjsip would offer the requested formats in addition to the configured codecs while trunk only currently offers the requested codecs if any are available. This does not affect the operation of PJSIP_MEDIA_OFFER() dialplan function.
> 
> 
> Diffs
> -----
> 
>   team/group/media_formats-reviewed-trunk/res/res_pjsip_session.c 418507 
>   team/group/media_formats-reviewed-trunk/main/format_cap.c 418507 
>   team/group/media_formats-reviewed-trunk/include/asterisk/format_cap.h 418507 
> 
> Diff: https://reviewboard.asterisk.org/r/3784/diff/
> 
> 
> Testing
> -------
> 
> Ensured that calls could be placed that were previously rejected or did not operate properly.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140714/ab9416e0/attachment.html>