<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3784/">https://reviewboard.asterisk.org/r/3784/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please do make sure that a unit test gets written for this as well.</pre>
<br />
<p>- Matt Jordan</p>
<br />
<p>On July 14th, 2014, 2:21 p.m. CDT, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Corey Farrell, Joshua Colp, and Matt Jordan.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated July 14, 2014, 2:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes the codecs that chan_pjsip offers on outbound call attempts. chan_pjsip will now offer the endpoint-configured codec preferences with requested formats replacing equivalent configured formats. Previously, chan_pjsip would offer the requested formats in addition to the configured codecs while trunk only currently offers the requested codecs if any are available. This does not affect the operation of PJSIP_MEDIA_OFFER() dialplan function.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensured that calls could be placed that were previously rejected or did not operate properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>team/group/media_formats-reviewed-trunk/res/res_pjsip_session.c <span style="color: grey">(418507)</span></li>
<li>team/group/media_formats-reviewed-trunk/main/format_cap.c <span style="color: grey">(418507)</span></li>
<li>team/group/media_formats-reviewed-trunk/include/asterisk/format_cap.h <span style="color: grey">(418507)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3784/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>