[asterisk-dev] [Code Review] 3698: Remove deprecated modules and options (Round #1)

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3698/
-----------------------------------------------------------

(Updated July 3, 2014, 9:42 a.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed findings; pval in AEL now uses MSet exclusively.


Repository: Asterisk


Description
-------

Per the discussion on the asterisk-dev mailing list [1], this patch removes the following:

* cdr_sqlite
* chan_gtalk
* chan_jingle
* chan_h323
* res_jabber
* app_saycountpl
* app_readfile
* app_dahdibarge

It removes the following applications/functions:

* WaitMusicOnHold
* SetMusicOnHold
* SIPCHANINFO

And it removes the colon delimiter from the SIPPEER function.

It also removes all compatibility options that were configurable from asterisk.conf, as these all applied to compatibility with Asterisk 1.4 systems.

Corey pointed out a number of other deprecated applications/functions, and those should get removed as well - but I wanted to get round #1 up and going since the channel drivers in particular are a bit odious with the media rework going on.

[1] http://lists.digium.com/pipermail/asterisk-dev/2014-June/068363.html


Diffs (updated)
-----

  /trunk/utils/conf2ael.c 417800 
  /trunk/utils/ael_main.c 417800 
  /trunk/res/res_musiconhold.c 417800 
  /trunk/res/res_jabber.c 417800 
  /trunk/res/res_agi.c 417800 
  /trunk/res/ael/pval.c 417800 
  /trunk/pbx/pbx_realtime.c 417800 
  /trunk/main/pbx.c 417800 
  /trunk/main/asterisk.c 417800 
  /trunk/include/asterisk/options.h 417800 
  /trunk/configs/jingle.conf.sample 417800 
  /trunk/configs/jabber.conf.sample 417800 
  /trunk/configs/gtalk.conf.sample 417800 
  /trunk/configs/asterisk.conf.sample 417800 
  /trunk/channels/h323/noexport.map 417800 
  /trunk/channels/h323/compat_h323.cxx 417800 
  /trunk/channels/h323/compat_h323.h 417800 
  /trunk/channels/h323/cisco-h225.cxx 417800 
  /trunk/channels/h323/cisco-h225.h 417800 
  /trunk/channels/h323/cisco-h225.asn 417800 
  /trunk/channels/h323/chan_h323.h 417800 
  /trunk/channels/h323/caps_h323.cxx 417800 
  /trunk/channels/h323/caps_h323.h 417800 
  /trunk/channels/h323/ast_ptlib.h 417800 
  /trunk/channels/h323/ast_h323.cxx 417800 
  /trunk/channels/h323/ast_h323.h 417800 
  /trunk/channels/h323/TODO 417800 
  /trunk/channels/h323/README 417800 
  /trunk/channels/h323/Makefile.in 417800 
  /trunk/channels/h323/INSTALL.openh323 417800 
  /trunk/channels/h323/ChangeLog 417800 
  /trunk/channels/chan_sip.c 417800 
  /trunk/channels/chan_jingle.c 417800 
  /trunk/channels/chan_h323.c 417800 
  /trunk/channels/chan_gtalk.c 417800 
  /trunk/channels/Makefile 417800 
  /trunk/apps/app_readfile.c 417800 
  /trunk/apps/app_dahdibarge.c 417800 
  /trunk/addons/app_saycountpl.c 417800 
  /trunk/addons/Makefile 417800 
  /trunk/UPGRADE.txt 417800 
  /trunk/CHANGES 417800 

Diff: https://reviewboard.asterisk.org/r/3698/diff/


Testing
-------

Asterisk compiles without the various modules and loads correctly.


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140703/4e8268cb/attachment.html>