<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3698/">https://reviewboard.asterisk.org/r/3698/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated July 3, 2014, 9:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed findings; pval in AEL now uses MSet exclusively.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Per the discussion on the asterisk-dev mailing list [1], this patch removes the following:
* cdr_sqlite
* chan_gtalk
* chan_jingle
* chan_h323
* res_jabber
* app_saycountpl
* app_readfile
* app_dahdibarge
It removes the following applications/functions:
* WaitMusicOnHold
* SetMusicOnHold
* SIPCHANINFO
And it removes the colon delimiter from the SIPPEER function.
It also removes all compatibility options that were configurable from asterisk.conf, as these all applied to compatibility with Asterisk 1.4 systems.
Corey pointed out a number of other deprecated applications/functions, and those should get removed as well - but I wanted to get round #1 up and going since the channel drivers in particular are a bit odious with the media rework going on.
[1] http://lists.digium.com/pipermail/asterisk-dev/2014-June/068363.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Asterisk compiles without the various modules and loads correctly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/utils/conf2ael.c <span style="color: grey">(417800)</span></li>
<li>/trunk/utils/ael_main.c <span style="color: grey">(417800)</span></li>
<li>/trunk/res/res_musiconhold.c <span style="color: grey">(417800)</span></li>
<li>/trunk/res/res_jabber.c <span style="color: grey">(417800)</span></li>
<li>/trunk/res/res_agi.c <span style="color: grey">(417800)</span></li>
<li>/trunk/res/ael/pval.c <span style="color: grey">(417800)</span></li>
<li>/trunk/pbx/pbx_realtime.c <span style="color: grey">(417800)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(417800)</span></li>
<li>/trunk/main/asterisk.c <span style="color: grey">(417800)</span></li>
<li>/trunk/include/asterisk/options.h <span style="color: grey">(417800)</span></li>
<li>/trunk/configs/jingle.conf.sample <span style="color: grey">(417800)</span></li>
<li>/trunk/configs/jabber.conf.sample <span style="color: grey">(417800)</span></li>
<li>/trunk/configs/gtalk.conf.sample <span style="color: grey">(417800)</span></li>
<li>/trunk/configs/asterisk.conf.sample <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/noexport.map <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/compat_h323.cxx <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/compat_h323.h <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/cisco-h225.cxx <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/cisco-h225.h <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/cisco-h225.asn <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/chan_h323.h <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/caps_h323.cxx <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/caps_h323.h <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/ast_ptlib.h <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/ast_h323.cxx <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/ast_h323.h <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/TODO <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/README <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/Makefile.in <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/INSTALL.openh323 <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/h323/ChangeLog <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/chan_jingle.c <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/chan_h323.c <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/chan_gtalk.c <span style="color: grey">(417800)</span></li>
<li>/trunk/channels/Makefile <span style="color: grey">(417800)</span></li>
<li>/trunk/apps/app_readfile.c <span style="color: grey">(417800)</span></li>
<li>/trunk/apps/app_dahdibarge.c <span style="color: grey">(417800)</span></li>
<li>/trunk/addons/app_saycountpl.c <span style="color: grey">(417800)</span></li>
<li>/trunk/addons/Makefile <span style="color: grey">(417800)</span></li>
<li>/trunk/UPGRADE.txt <span style="color: grey">(417800)</span></li>
<li>/trunk/CHANGES <span style="color: grey">(417800)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3698/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>