[asterisk-dev] [Code Review] 3660: testsuite: A rather comprehensive set of tests for DialplanAdd/RemoveExtension AMI commands

[Jonathan Rose]

> On July 1, 2014, 1:40 p.m., opticron wrote:
> > /asterisk/trunk/tests/pbx/manager_extensions/ami_extension_control.py, line 40
> > <https://reviewboard.asterisk.org/r/3660/diff/4/?file=61095#file61095line40>
> >
> >     There is no need for a deep copy here since you don't touch the original after originating the calls.

This is probably a bit of paranoia on my part, but I don't want to mess with the originate list before originating all the calls and I have no guarantee that any given originate will begin before a previous originate's hangup response arrives. I figured the peace of mind was worthwhile since the deep copy doesn't really add any appreciable amount of time to the test.

If not though, sure, I can get rid of it and just cull from the original list.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3660/#review12418
-----------------------------------------------------------


On June 26, 2014, 5:30 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3660/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 5:30 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Matt Jordan.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> 11 part test:
>  1 - Remove an extension with a priority
>      If the manager command fails, a failure token will be set
>      If the original extension runs, a user event will be generated that makes the test fail
> 
>  2 - Remove an entire existing extension
>      If the manager command fails, a failure token will be set
>      If the original extension runs, a user event will be generated that makes the test fail
> 
>  3 - Add an extension
>      If the manager command fails, a failure token will be set
>      If the extension fails to run, an expected user event will not be generated and the test will fail
> 
>  4 - Add an extension with a CID match that doesn't match the originated channel
>      If the manager command fails, a failure token will be set
>      If the extension runs, a user event will be generated that makes the test fail
> 
>  5 - Add an extension with a CID match that should match the originated channel
>      If the manager command fails, a failure token will be set
>      If the extension fails to run, an expected user event will not be generated and the test will fail
> 
>  6 - Add an extension that replaces an existing priority
>      If the manager command fails, a failure token will be set
>      If the original extension runs, a user event will be generated that makes the test fail
>      If the replacement extension doesn't run, an expected user event will not be generated and the test will fail
> 
>  7 - Attempt to add an extension that would replace an existing priority, but don't allow replacement
>      If the manager command doesn't fail, a failure token will be set
>      If the original extension doesn't run, an expected user event will not be generated and the test will fail
>      If the replacement extension runs, a user event will be generated that makes the test fail
> 
>  8 - Remove an extension at a specific priority with caller ID matching
>      If the manager command fails, a failure token will be set
>      If the original extension runs, a user event will be generated that makes the test fail
>      The originate is checked by means of a user event on a separate priority taht is not removed
> 
>  9 - Attempt DialplanAddExtension without priority set
>      If the manager command doesn't fail, a failure token will be set
> 
> 10 - Attempt DialplanAddExtension without application set
>      If the manager command doesn't fail, a failure token will be set
> 
> 11 - Attempt DialplanRemoveExtension on an extension that does not exist
>      If the manager command doesn't fail, a failure token will be set
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/pbx/tests.yaml 5144 
>   /asterisk/trunk/tests/pbx/manager_extensions/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/pbx/manager_extensions/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/pbx/manager_extensions/ami_extension_control.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3660/diff/
> 
> 
> Testing
> -------
> 
> Removed execution of many of the test AMI commands to guarantee that if above failures occurred that the test would fail
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140702/06536f4c/attachment.html>