[asterisk-dev] [Code Review] 3660: testsuite: A rather comprehensive set of tests for DialplanAdd/RemoveExtension AMI commands

[Jonathan Rose]

> On July 1, 2014, 1:40 p.m., opticron wrote:
> > /asterisk/trunk/tests/pbx/manager_extensions/test-config.yaml, line 34
> > <https://reviewboard.asterisk.org/r/3660/diff/4/?file=61097#file61097line34>
> >
> >     This test doesn't seem to actually use the ActionIDs provided for the defined commands.

It's for diagnostic purposes in case one or more of the action responses doesn't match with the expectations. The full response will show up in the failure token error message and the ActionID will be with it.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3660/#review12418
-----------------------------------------------------------


On June 26, 2014, 5:30 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3660/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 5:30 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Matt Jordan.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> 11 part test:
>  1 - Remove an extension with a priority
>      If the manager command fails, a failure token will be set
>      If the original extension runs, a user event will be generated that makes the test fail
> 
>  2 - Remove an entire existing extension
>      If the manager command fails, a failure token will be set
>      If the original extension runs, a user event will be generated that makes the test fail
> 
>  3 - Add an extension
>      If the manager command fails, a failure token will be set
>      If the extension fails to run, an expected user event will not be generated and the test will fail
> 
>  4 - Add an extension with a CID match that doesn't match the originated channel
>      If the manager command fails, a failure token will be set
>      If the extension runs, a user event will be generated that makes the test fail
> 
>  5 - Add an extension with a CID match that should match the originated channel
>      If the manager command fails, a failure token will be set
>      If the extension fails to run, an expected user event will not be generated and the test will fail
> 
>  6 - Add an extension that replaces an existing priority
>      If the manager command fails, a failure token will be set
>      If the original extension runs, a user event will be generated that makes the test fail
>      If the replacement extension doesn't run, an expected user event will not be generated and the test will fail
> 
>  7 - Attempt to add an extension that would replace an existing priority, but don't allow replacement
>      If the manager command doesn't fail, a failure token will be set
>      If the original extension doesn't run, an expected user event will not be generated and the test will fail
>      If the replacement extension runs, a user event will be generated that makes the test fail
> 
>  8 - Remove an extension at a specific priority with caller ID matching
>      If the manager command fails, a failure token will be set
>      If the original extension runs, a user event will be generated that makes the test fail
>      The originate is checked by means of a user event on a separate priority taht is not removed
> 
>  9 - Attempt DialplanAddExtension without priority set
>      If the manager command doesn't fail, a failure token will be set
> 
> 10 - Attempt DialplanAddExtension without application set
>      If the manager command doesn't fail, a failure token will be set
> 
> 11 - Attempt DialplanRemoveExtension on an extension that does not exist
>      If the manager command doesn't fail, a failure token will be set
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/pbx/tests.yaml 5144 
>   /asterisk/trunk/tests/pbx/manager_extensions/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/pbx/manager_extensions/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/pbx/manager_extensions/ami_extension_control.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3660/diff/
> 
> 
> Testing
> -------
> 
> Removed execution of many of the test AMI commands to guarantee that if above failures occurred that the test would fail
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140702/daad123c/attachment.html>