[asterisk-dev] [Code Review] 3156: rtp_engine: improved handling of get_rtp_info failure

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3156/
-----------------------------------------------------------

(Updated Jan. 24, 2014, 7:08 p.m.)


Review request for Asterisk Developers.


Changes
-------

Correction per review.


Bugs: AST-1276
    https://issues.asterisk.org/jira/browse/AST-1276


Repository: Asterisk


Description
-------

This corrects an invalid ao2_ref operation on a null pointer that occurs when get_rtp_info fails, which gives a misleading warning (looks like ao2 ref problem, isn't).  Additionally, I've broken out the failure conditions with individual descriptive LOG_ERROR messages to be more helpful with diagnostics.
 


Diffs (updated)
-----

  /branches/1.8/main/rtp_engine.c 406358 

Diff: https://reviewboard.asterisk.org/r/3156/diff/


Testing
-------


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140125/71b0fabf/attachment.html>