[asterisk-dev] [Code Review] 3156: rtp_engine: improved handling of get_rtp_info failure

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3156/#review10698
-----------------------------------------------------------



/branches/1.8/main/rtp_engine.c
<https://reviewboard.asterisk.org/r/3156/#comment20202>

    Space after comma in the error messages.
    
    I'm not sure that these messages are needed anyway.


- rmudgett


On Jan. 24, 2014, 2:24 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3156/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 2:24 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AST-1276
>     https://issues.asterisk.org/jira/browse/AST-1276
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This corrects an invalid ao2_ref operation on a null pointer that occurs when get_rtp_info fails, which gives a misleading warning (looks like ao2 ref problem, isn't).  Additionally, I've broken out the failure conditions with individual descriptive LOG_ERROR messages to be more helpful with diagnostics.
>  
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/rtp_engine.c 406358 
> 
> Diff: https://reviewboard.asterisk.org/r/3156/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140125/ca22f361/attachment.html>