[asterisk-dev] [Code Review] 3124: res_pjsip: AOR option qualify_frequency not respected on startup

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3124/
-----------------------------------------------------------

(Updated Jan. 13, 2014, 2:48 p.m.)


Review request for Asterisk Developers.


Changes
-------

Changed a couple of variables to not use RAII_VAR.  Also fixed a bug on reload where qualifies were being added, but not being removed from the scheduler.  This resulted the existance of multiple scheduled qualifies for a contact.


Bugs: ASTERISK-23062
    https://issues.asterisk.org/jira/browse/ASTERISK-23062


Repository: Asterisk


Description
-------

If an endpoint had previously dynamically registered a contact and the contact information was successfully stored in astdb then upon restart the qualify notifications would not be sent out if the qualify_frequency was set.  This was due to the fact that only permanent contacts were being checked and scheduled for qualifies on startup.  Modified the code to check and schedule all registered contacts at startup.


Diffs (updated)
-----

  branches/12/res/res_pjsip/pjsip_options.c 405361 

Diff: https://reviewboard.asterisk.org/r/3124/diff/


Testing
-------

Using cli commands noted that qualifies are now being sent out for dynamically registered contacts that had been stored in the astdb and loaded at system start.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140113/84bbf55b/attachment.html>