[asterisk-dev] [Code Review] 3124: res_pjsip: AOR option qualify_frequency not respected on startup

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3124/#review10577
-----------------------------------------------------------

Ship it!


Besides my wish to kill excessive RAII_VAR usage this looks good.


branches/12/res/res_pjsip/pjsip_options.c
<https://reviewboard.asterisk.org/r/3124/#comment20039>

    Let's kill this usage of RAII_VAR whilst you are here.



branches/12/res/res_pjsip/pjsip_options.c
<https://reviewboard.asterisk.org/r/3124/#comment20040>

    Same here, let's kill it.


- Joshua Colp


On Jan. 13, 2014, 6:33 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3124/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 6:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23062
>     https://issues.asterisk.org/jira/browse/ASTERISK-23062
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> If an endpoint had previously dynamically registered a contact and the contact information was successfully stored in astdb then upon restart the qualify notifications would not be sent out if the qualify_frequency was set.  This was due to the fact that only permanent contacts were being checked and scheduled for qualifies on startup.  Modified the code to check and schedule all registered contacts at startup.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip/pjsip_options.c 405361 
> 
> Diff: https://reviewboard.asterisk.org/r/3124/diff/
> 
> 
> Testing
> -------
> 
> Using cli commands noted that qualifies are now being sent out for dynamically registered contacts that had been stored in the astdb and loaded at system start.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140113/33817a80/attachment.html>