[asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3117/
-----------------------------------------------------------

(Updated Jan. 9, 2014, 5:38 p.m.)


Review request for Asterisk Developers, Matt Jordan and Mark Michelson.


Changes
-------

Change module info flag to AST_MODFLAG_GLOBAL_SYMBOLS since changing that flag broke the functionality here.

This causes some awkward loading problems that need to be addressed.


Repository: Asterisk


Description
-------

This patch adds the ability to interface with res_external_mwi via AMI.  The following commands are implemented:

PUT mailboxes/mailboxName
    modifies mailbox state and implicitly creates new mailboxes

GET mailboxes/mailboxName
    retrieves a JSON representation of a single mailbox if it exists

GET mailboxes
    retrieves a JSON array of all mailboxes

DELETE mailbox/mailboxName
    deletes a mailbox

Thanks to Richard's external MWI work, this is actually a very simple system.


Diffs (updated)
-----

  /branches/12/rest-api/resources.json 405265 
  /branches/12/rest-api/api-docs/mailboxes.json PRE-CREATION 
  /branches/12/res/res_stasis_mailbox.exports.in PRE-CREATION 
  /branches/12/res/res_stasis_mailbox.c PRE-CREATION 
  /branches/12/res/res_ari_mailboxes.c PRE-CREATION 
  /branches/12/res/ari/resource_mailboxes.c PRE-CREATION 
  /branches/12/res/ari/resource_mailboxes.h PRE-CREATION 
  /branches/12/res/ari/ari_model_validators.c 405265 
  /branches/12/res/ari/ari_model_validators.h 405265 
  /branches/12/res/ari.make 405265 
  /branches/12/include/asterisk/stasis_app_mailbox.h PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3117/diff/


Testing
-------

Tested unloads and reloads of the res_stasis_mailboxes module with res_mwi_external loaded and unloaded
Tested how commands respond from resource_mailboxes when res_stasis_mailboxes isn't loaded
Tested each of the commands with numerous parameters
Created testsuite test in https://reviewboard.asterisk.org/r/3118/ which confirms basic operation of all the new ARI functions.


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140109/6c0da623/attachment-0001.html>