<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3117/">https://reviewboard.asterisk.org/r/3117/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers, Matt Jordan and Mark Michelson.</div>
<div>By Jonathan Rose.</div>


<p style="color: grey;"><i>Updated Jan. 9, 2014, 5:38 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change module info flag to AST_MODFLAG_GLOBAL_SYMBOLS since changing that flag broke the functionality here.

This causes some awkward loading problems that need to be addressed.</pre>
  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds the ability to interface with res_external_mwi via AMI.  The following commands are implemented:

PUT mailboxes/mailboxName
    modifies mailbox state and implicitly creates new mailboxes

GET mailboxes/mailboxName
    retrieves a JSON representation of a single mailbox if it exists

GET mailboxes
    retrieves a JSON array of all mailboxes

DELETE mailbox/mailboxName
    deletes a mailbox

Thanks to Richard's external MWI work, this is actually a very simple system.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested unloads and reloads of the res_stasis_mailboxes module with res_mwi_external loaded and unloaded
Tested how commands respond from resource_mailboxes when res_stasis_mailboxes isn't loaded
Tested each of the commands with numerous parameters
Created testsuite test in https://reviewboard.asterisk.org/r/3118/ which confirms basic operation of all the new ARI functions.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/12/rest-api/resources.json <span style="color: grey">(405265)</span></li>

 <li>/branches/12/rest-api/api-docs/mailboxes.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/branches/12/res/res_stasis_mailbox.exports.in <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/branches/12/res/res_stasis_mailbox.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/branches/12/res/res_ari_mailboxes.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/branches/12/res/ari/resource_mailboxes.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/branches/12/res/ari/resource_mailboxes.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/branches/12/res/ari/ari_model_validators.c <span style="color: grey">(405265)</span></li>

 <li>/branches/12/res/ari/ari_model_validators.h <span style="color: grey">(405265)</span></li>

 <li>/branches/12/res/ari.make <span style="color: grey">(405265)</span></li>

 <li>/branches/12/include/asterisk/stasis_app_mailbox.h <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3117/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>